gitlab bot: start refactoring code review methods
the code review logic to this point is kind of convoluted, and still is for the moment, but this moves some of the stuff into a more coherent spot in the expectation of reuse. most of the refactoring is still to come
This commit is contained in:
parent
8f7b477fb8
commit
e846502b48
|
@ -91,7 +91,12 @@ class GitlabBot(object):
|
||||||
|
|
||||||
return approve_count, approvers, send_reset
|
return approve_count, approvers, send_reset
|
||||||
|
|
||||||
def scan_for_reviews(self, project, project_obj, merge_request):
|
def scan_project_for_reviews(self, project):
|
||||||
|
project_obj = self.client.projects.get(project.project_id)
|
||||||
|
if not project_obj:
|
||||||
|
return
|
||||||
|
|
||||||
|
for merge_request in project_obj.mergerequests.list(state='opened'):
|
||||||
log.debug("scanning merge request '%s'", merge_request.title)
|
log.debug("scanning merge request '%s'", merge_request.title)
|
||||||
|
|
||||||
# check to see if the merge request needs a reviewer or a merge
|
# check to see if the merge request needs a reviewer or a merge
|
||||||
|
|
|
@ -17,6 +17,4 @@ class Command(BaseCommand):
|
||||||
bot = GitlabBot()
|
bot = GitlabBot()
|
||||||
projects = GitlabProjectConfig.objects.filter(manage_merge_request_code_reviews=True)
|
projects = GitlabProjectConfig.objects.filter(manage_merge_request_code_reviews=True)
|
||||||
for project in projects:
|
for project in projects:
|
||||||
project_obj = bot.client.projects.get(project.project_id)
|
bot.scan_project_for_reviews(project)
|
||||||
for merge_request in project_obj.mergerequests.list(state='opened'):
|
|
||||||
bot.scan_for_reviews(project, project_obj, merge_request)
|
|
||||||
|
|
Loading…
Reference in New Issue