Improvement: redirect symlink-dir/ to target-dir/, not target #10

New Issue

bss · 2021-04-17T10:33:33-05:00

bss commented

2021-04-17 10:33:33 -05:00

As of 60715a3a5c the request path to instance path conversion follows symlinks verbatim, so if the client requests /symlink-to-foo/, the code reads the "symlink-to-foo -> foo" link and accordingly redirects to /foo. This is fine, but requesting /foo will itself need a redirect to get to /foo/, the actual target.

I don't have an idea to fix this right now but maybe we can do something. It just saves a redirect so I'm not super worried about it.

As of 60715a3a5c5301ee44aaeedd151248171a002dd1 the request path to instance path conversion follows symlinks verbatim, so if the client requests `/symlink-to-foo/`, the code reads the "`symlink-to-foo -> foo`" link and accordingly redirects to `/foo`. This is fine, but requesting `/foo` will itself need a redirect to get to `/foo/`, the actual target. I don't have an idea to fix this right now but maybe we can do something. It just saves a redirect so I'm not super worried about it.

bss added the

enhancement

label 2022-01-17 16:48:33 -06:00

Sign in to join this conversation.