test the ability to not learn our nick when addressed

markov/ircplugin.py

@@ -73,23 +73,24 @@ class Markov(Plugin):
             log.debug("not learning from %s as i've been told to ignore it", channel)
         else:
             # learn the line
+            learning_what = what
             # remove our own nick and aliases from what we learn
             if connection.server_config.additional_addressed_nicks:
                 all_nicks = '|'.join(connection.server_config.additional_addressed_nicks.split('\n') +
                                      [connection.get_nickname()])
             else:
                 all_nicks = connection.get_nickname()
-            what = re.sub(r'^(({nicks})[:,]|@({nicks}))\s+'.format(nicks=all_nicks), '', what)
+            learning_what = re.sub(r'^(({nicks})[:,]|@({nicks}))\s+'.format(nicks=all_nicks), '', learning_what)
 
             # don't learn the speaker's nick if this came over a bridge
             if channel and who == channel.discord_bridge:
-                what = ' '.join(what.split(' ')[1:])
+                learning_what = ' '.join(learning_what.split(' ')[1:])
 
             recursing = getattr(event, 'recursing', False)
             if not recursing:
-                log.debug("learning %s", what)
+                log.debug("learning %s", learning_what)
                 context = markovlib.get_or_create_target_context(target)
-                markovlib.learn_line(what, context)
+                markovlib.learn_line(learning_what, context)
 
         log.debug("searching '%s' for '%s'", what, all_nicks)
         if re.search(all_nicks, what, re.IGNORECASE) is not None:

tests/test_markov_ircplugin.py

@@ -42,7 +42,8 @@ class MarkovTestCase(TestCase):
         mock_event.recursing = False
 
         with mock.patch('markov.lib.learn_line') as mock_learn_line:
-            self.plugin.handle_chatter(self.mock_connection, mock_event)
+            with mock.patch('markov.lib.generate_line'):
+                self.plugin.handle_chatter(self.mock_connection, mock_event)
 
         self.assertEqual(mock_learn_line.call_args.args[0], 'hello this is a test message')
 
@@ -54,7 +55,8 @@ class MarkovTestCase(TestCase):
         mock_event.recursing = False
 
         with mock.patch('markov.lib.learn_line') as mock_learn_line:
-            self.plugin.handle_chatter(self.mock_connection, mock_event)
+            with mock.patch('markov.lib.generate_line'):
+                self.plugin.handle_chatter(self.mock_connection, mock_event)
 
         self.assertEqual(mock_learn_line.call_args.args[0], 'hello this is a test message')