when assigning a new user for review/acceptance, use their real name in
the message, not their username (the reassign will include their
username a split second later anyway)
bot was overzealous in logging the approval reset message when seeing
pushes. this commit should keep it from logging the message if a push
happened but there weren't actually any approvals yet (so there's
nothing to reset)
still waiting on testing, but this seems like a decent fix to me
bss/dr.botzo#4
this moves a bunch of code around and renames a bunch of things, so the
diff for it is fairly huge, but it's the same general idea, just
organized better. woo.
the code review logic to this point is kind of convoluted, and still is
for the moment, but this moves some of the stuff into a more coherent
spot in the expectation of reuse. most of the refactoring is still to
come
the intent of this thing is to scan configured projects' merge requests,
and automatically assign them to designated code reviewers. if someone
says "LGTM" in the merge request thread, that counts as a review and the
bot either selects another reviewer or assigns the thing to a designated
merge approver for the final approval and merge
this is most of the way there, but not done yet. things still to do:
1) more strings than "LGTM", but we should be careful to avoid things
that someone might actually say
2) i'm trying to avoid it but i probably need to track the 2 of 2
reviewer message separate from the message assigning the merge
request to an approver. it's plausible that a reviewer is also an
approver, and if the last reviewer is a candidate approver, the
script does nothing, but we probably want it to still log the 2 of 2
part. i could track the "nagging" for 2 of 2 messages, to avoid
the bot repeating itself, but that seems unfortunately annoying