Added get_stripped_html_for_object. Renamed a few things

This commit is contained in:
Rin Toshaka 2018-12-30 16:51:16 +01:00
parent bce152aba0
commit d9f40b05b3
3 changed files with 32 additions and 9 deletions

View File

@ -262,10 +262,13 @@ def emoji_from_profile(%{info: _info} = user) do
end) end)
end end
def get_scrubbed_html_for_object(content, scrubber, activity) when is_atom(scrubber) do
get_scrubbed_html_for_object(content, [scrubber], activity)
end
@doc """ @doc """
Get sanitized HTML from cache, or scrub it and save to cache. Get sanitized HTML from cache, or scrub it and save to cache.
""" """
def get_scrubbed_html( def get_scrubbed_html_for_object(
content, content,
scrubbers, scrubbers,
%{data: %{"object" => object}} = activity %{data: %{"object" => object}} = activity
@ -281,7 +284,7 @@ def get_scrubbed_html(
{new_scrubber_cache, scrubbed_html} = {new_scrubber_cache, scrubbed_html} =
Enum.map_reduce(scrubber_cache, nil, fn Enum.map_reduce(scrubber_cache, nil, fn
entry, _content -> entry, content ->
if Map.keys(entry["scrubbers"]) == Map.keys(signature) do if Map.keys(entry["scrubbers"]) == Map.keys(signature) do
if entry["scrubbers"] == signature do if entry["scrubbers"] == signature do
{entry, entry["content"]} {entry, entry["content"]}
@ -289,6 +292,8 @@ def get_scrubbed_html(
# Remove the entry if scrubber version is outdated # Remove the entry if scrubber version is outdated
{nil, nil} {nil, nil}
end end
else
{entry, content}
end end
end) end)
@ -297,15 +302,30 @@ def get_scrubbed_html(
if scrubbed_html == nil or new_scrubber_cache != scrubber_cache do if scrubbed_html == nil or new_scrubber_cache != scrubber_cache do
scrubbed_html = HTML.filter_tags(content, scrubbers) scrubbed_html = HTML.filter_tags(content, scrubbers)
new_scrubber_cache = [%{:scrubbers => signature, :content => scrubbed_html} | new_scrubber_cache]
new_scrubber_cache = [
%{:scrubbers => signature, :content => scrubbed_html} | new_scrubber_cache
]
update_scrubber_cache(activity, new_scrubber_cache) update_scrubber_cache(activity, new_scrubber_cache)
scrubbed_html
else
scrubbed_html
end end
scrubbed_html
end end
defp generate_scrubber_signature(scrubbers) do defp generate_scrubber_signature(scrubbers) do
Enum.reduce(scrubbers, %{}, fn scrubber, signature -> Enum.reduce(scrubbers, %{}, fn scrubber, signature ->
Map.put(signature, to_string(scrubber), scrubber.version) Map.put(
signature,
to_string(scrubber),
# If a scrubber does not have a version(e.g HtmlSanitizeEx.Scrubber) it is assumed it is always 0)
if Kernel.function_exported?(scrubber, :version, 0) do
scrubber.version
else
0
end
)
end) end)
end end
@ -317,4 +337,8 @@ defp update_scrubber_cache(activity, scrubber_cache) do
{:ok, _struct} = Repo.update(cng) {:ok, _struct} = Repo.update(cng)
end end
def get_stripped_html_for_object(content, activity) do
get_scrubbed_html_for_object(content, [HtmlSanitizeEx.Scrubber.StripTags], activity)
end
end end

View File

@ -120,7 +120,7 @@ def render("status.json", %{activity: %{data: %{"object" => object}} = activity}
content = content =
object object
|> render_content() |> render_content()
|> Utils.get_scrubbed_html(User.html_filter_policy(opts[:for]), activity) |> Utils.get_scrubbed_html_for_object(User.html_filter_policy(opts[:for]), activity)
%{ %{
id: to_string(activity.id), id: to_string(activity.id),

View File

@ -15,7 +15,6 @@ defmodule Pleroma.Web.TwitterAPI.ActivityView do
alias Pleroma.User alias Pleroma.User
alias Pleroma.Repo alias Pleroma.Repo
alias Pleroma.Formatter alias Pleroma.Formatter
alias Pleroma.HTML
import Ecto.Query import Ecto.Query
require Logger require Logger
@ -245,14 +244,14 @@ def render(
html = html =
content content
|> Utils.get_scrubbed_html(User.html_filter_policy(opts[:for]), activity) |> Utils.get_scrubbed_html_for_object(User.html_filter_policy(opts[:for]), activity)
|> Formatter.emojify(object["emoji"]) |> Formatter.emojify(object["emoji"])
text = text =
if content do if content do
content content
|> String.replace(~r/<br\s?\/?>/, "\n") |> String.replace(~r/<br\s?\/?>/, "\n")
|> HTML.strip_tags() |> Utils.get_stripped_html_for_object(activity)
end end
reply_parent = Activity.get_in_reply_to_activity(activity) reply_parent = Activity.get_in_reply_to_activity(activity)