Use with w/ pack_info_res

lib/pleroma/web/emoji_api/emoji_api_controller.ex

@@ -183,19 +183,13 @@ def download_from(conn, %{"instance_address" => address, "pack_name" => name} =
           {:error, "The pack was not set as shared and there is no fallback src to download from"}
       end
 
-    case pack_info_res do
-      {:ok, %{sha: sha, uri: uri} = pinfo} ->
-        sha = Base.decode16!(sha)
-        emoji_archive = Tesla.get!(uri).body
-
-        got_sha = :crypto.hash(:sha256, emoji_archive)
-
-        if got_sha == sha do
+    with {:ok, %{sha: sha, uri: uri} = pinfo} <- pack_info_res,
+         %{body: emoji_archive} <- Tesla.get!(uri),
+         {_, true} <- {:sha, Base.decode16!(sha) == :crypto.hash(:sha256, emoji_archive)} do
       local_name = data["as"] || name
       pack_dir = Path.join(@emoji_dir_path, local_name)
       File.mkdir_p!(pack_dir)
 
-          # Fallback cannot contain a pack.json file
       files = Enum.map(full_pack["files"], fn {_, path} -> to_charlist(path) end)
       # Fallback cannot contain a pack.json file
       files = if pinfo[:fallback], do: files, else: ['pack.json'] ++ files
@@ -210,16 +204,16 @@ def download_from(conn, %{"instance_address" => address, "pack_name" => name} =
         File.write!(pack_file_path, Jason.encode!(full_pack, pretty: true))
       end
 
-          conn |> text("ok")
+      text(conn, "ok")
     else
+      {:error, e} ->
+        conn |> put_status(:internal_server_error) |> text(e)
+
+      {:sha, _} ->
         conn
         |> put_status(:internal_server_error)
         |> text("SHA256 for the pack doesn't match the one sent by the server")
     end
-
-      {:error, e} ->
-        conn |> put_status(:internal_server_error) |> text(e)
-    end
   end
 
   @doc """