From 7d34cec58d0a9fda1741e1c0c9c23b0895a2cc2e Mon Sep 17 00:00:00 2001 From: Roger Braun Date: Wed, 9 Aug 2017 16:55:18 +0200 Subject: [PATCH] escape attachment urls on creation. --- lib/pleroma/web/twitter_api/utils.ex | 2 +- test/web/twitter_api/twitter_api_utils_test.exs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pleroma/web/twitter_api/utils.ex b/lib/pleroma/web/twitter_api/utils.ex index 2c3507dfb..cd7e04ca1 100644 --- a/lib/pleroma/web/twitter_api/utils.ex +++ b/lib/pleroma/web/twitter_api/utils.ex @@ -12,7 +12,7 @@ def attachments_from_ids(ids) do def add_attachments(text, attachments) do attachment_text = Enum.map(attachments, fn (%{"url" => [%{"href" => href} | _]}) -> - "#{Path.basename(href)}" + "#{Path.basename(href)}" _ -> "" end) Enum.join([text | attachment_text], "
\n") diff --git a/test/web/twitter_api/twitter_api_utils_test.exs b/test/web/twitter_api/twitter_api_utils_test.exs index 62aa7843b..49818afed 100644 --- a/test/web/twitter_api/twitter_api_utils_test.exs +++ b/test/web/twitter_api/twitter_api_utils_test.exs @@ -9,6 +9,6 @@ test "it adds attachment links to a given text and attachment set" do res = Utils.add_attachments("", [attachment]) - assert res == "
\ni\"m a boy.png" + assert res == "
\ni\"m a boy.png" end end