Fix Reblog API

Do not set visibility parameter to `public` by default and let CommonAPI to infer it from status.
This commit is contained in:
Egor Kislitsyn 2021-01-18 20:15:57 +04:00
parent 732cc0ce46
commit 1b79dce7bc
No known key found for this signature in database
GPG Key ID: 1B49CB15B71E7805
3 changed files with 29 additions and 1 deletions

View File

@ -117,7 +117,7 @@ def reblog_operation do
request_body("Parameters", %Schema{ request_body("Parameters", %Schema{
type: :object, type: :object,
properties: %{ properties: %{
visibility: %Schema{allOf: [VisibilityScope], default: "public"} visibility: %Schema{allOf: [VisibilityScope]}
} }
}), }),
responses: %{ responses: %{

View File

@ -744,6 +744,17 @@ test "repeating a status privately" do
refute Visibility.visible_for_user?(announce_activity, nil) refute Visibility.visible_for_user?(announce_activity, nil)
end end
test "author can repeat own private statuses" do
user = insert(:user)
{:ok, activity} = CommonAPI.post(user, %{status: "cofe", visibility: "private"})
{:ok, %Activity{} = announce_activity} = CommonAPI.repeat(activity.id, user)
assert Visibility.is_private?(announce_activity)
refute Visibility.visible_for_user?(announce_activity, nil)
end
test "favoriting a status" do test "favoriting a status" do
user = insert(:user) user = insert(:user)
other_user = insert(:user) other_user = insert(:user)

View File

@ -954,6 +954,23 @@ test "reblogged status for another user" do
assert to_string(activity.id) == id assert to_string(activity.id) == id
end end
test "author can reblog own private status", %{conn: conn, user: user} do
{:ok, activity} = CommonAPI.post(user, %{status: "cofe", visibility: "private"})
conn =
conn
|> put_req_header("content-type", "application/json")
|> post("/api/v1/statuses/#{activity.id}/reblog")
assert %{
"reblog" => %{"id" => id, "reblogged" => true, "reblogs_count" => 1},
"reblogged" => true,
"visibility" => "private"
} = json_response_and_validate_schema(conn, 200)
assert to_string(activity.id) == id
end
end end
describe "unreblogging" do describe "unreblogging" do