don't put unrealircd's pidfile where unrealircd could write it

This commit is contained in:
Brian S. Stephan 2023-04-11 19:31:02 -05:00
parent 26e4c0d022
commit af16b851dc
Signed by: bss
GPG Key ID: 3DE06D3180895FCB
3 changed files with 3 additions and 11 deletions

View File

@ -4,7 +4,7 @@
# Defaults
: ${UNREALIRCD_CONF:=/etc/unrealircd/${SVCNAME}.conf}
: ${UNREALIRCD_PIDFILE:=/run/unrealircd/${SVCNAME#unreal}.pid}
: ${UNREALIRCD_PIDFILE:=/run/${SVCNAME#unreal}.pid}
# Convenience variable for the chroot bits, not actually user-controllable via conf.d
UNREALIRCD_USER="unrealircd"
@ -42,14 +42,7 @@ depend() {
provide ircd
}
# It is unsafe for the unrealircd user to be able to write to its own
# PID file, since root will be sending e.g. kill signals to the PID
# listed in that file. Ensure that we overwrite the ownership and
# permissions on /run/unrealircd from previous init scripts.
start_pre() {
# commented out pending information about where to do pidfile vs. socket stuff
# checkpath --directory --owner root:root --mode 0700 "${UNREALIRCD_CHROOT}"/run/unrealircd
checkconfig || return $?
}

View File

@ -1,2 +1 @@
d /run/unrealircd 755 unrealircd unrealircd

View File

@ -71,7 +71,7 @@ src_configure() {
--with-logdir="${EPREFIX}"/var/log/${PN} \
--with-modulesdir="${EPREFIX}/usr/$(get_libdir)"/${PN}/modules \
--without-privatelibdir \
--with-pidfile="${EPREFIX}"/run/${PN}/ircd.pid \
--with-pidfile="${EPREFIX}"/run/${PN}.pid \
--with-tmpdir="${EPREFIX}"/var/lib/${PN}/tmp \
--with-maxconnections=1024 \
--with-nick-history=2000 \
@ -82,7 +82,7 @@ src_configure() {
--with-system-sodium \
--with-system-jansson \
--enable-dynamic-linking \
--with-controlfile="${EPREFIX}"/run/${PN}/unrealircd.ctl \
--with-controlfile="${EPREFIX}"/run/${PN}/${PN}.ctl \
--enable-ssl="${EPREFIX}"/usr \
$(use_enable curl libcurl "${EPREFIX}"/usr) \
$(use_with !operoverride no-operoverride) \