From 03737e2385884bbaf0daf9473f9d30f772efffd2 Mon Sep 17 00:00:00 2001 From: "Brian S. Stephan" Date: Wed, 5 Mar 2025 08:30:34 -0600 Subject: [PATCH] use the derived frame piece y dimension to build side as in previous commit, this simplifies the build of the side frame piece a bit. notably on this one, the preview of the piece is more performant, so I'm thinking this is a good move. the object triangle count and volume are slightly different (not sure why), but the object dimensions are the same still didn't get rid of any 2-manifold errors though :( Signed-off-by: Brian S. Stephan --- src/frames/pieces/side.scad | 11 +++++++---- src/parameters.scad | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/frames/pieces/side.scad b/src/frames/pieces/side.scad index 6478d39..33a1575 100644 --- a/src/frames/pieces/side.scad +++ b/src/frames/pieces/side.scad @@ -5,18 +5,21 @@ include include +use use module side_frame_piece() { piece_width = panel_support_width+frame_wall+frame_mount_column_width; difference() { - // side piece is left/right agnostic - frame(); + intersection() { + left_frame(); + // include the whole left wall (including mount columns) + translate([-(frame_x/2)+(piece_width/2), 0, 0]) + cube([piece_width, frame_piece_y_y, frame_z], center=true); + } // minus the top and bottom front_or_back_frame_piece(); rotate([180, 0, 0]) front_or_back_frame_piece(); - // and just chop out the rest of the frame - translate([piece_width, 0, 0]) cube([frame_x, frame_y+1, frame_z+1], center=true); } } diff --git a/src/parameters.scad b/src/parameters.scad index 4463636..e3dd4a9 100644 --- a/src/parameters.scad +++ b/src/parameters.scad @@ -66,6 +66,7 @@ panel_z = 5; // some dimensions for frame pieces, useful in doing some intersections and chopping frame_piece_x_x = frame_x - (frame_wall * 2); // essentially panel_x, yes +frame_piece_y_y = frame_y; // the whole y of the frame, yes // degree to which the extended frame pieces stick out from the end of the frame frame_extension_x = 25;